On Wednesday 18 May 2016 10:16:11 Antonio Quartulli wrote: [...]
one very last question (sorry for not spotting this earlier): if we don't handle the TP meter with the icmp_socket anymore, why do we tight the TP initialization to the socket initialization ?
Is there any reason to have it here ? Or we should move the batadv_tp_meter_init() call to somewhere else ?
It was basically just because it is still bound to the ICMP stuff (even when it is not using the socket itself). But when thinking about it, then you are right. This should be moved to the global initialization. Not all ICMP handling is done in icmp_socket.c and thus this also doesn't have to be added here. main.c (batadv_init) is a better place for it.
[...]
- Return: 0 on success, <0 on error
you forgot the space between < and 0 ;P but if the rest is ok, I am sure Marek could add it :)
Can I just say that it is an copy+paste error from your comment in bat_v_ogm.c ;)
Kind regards, Sven