Andrew Lunn andrew@lunn.ch schrieb am 16.02.2011 07:16:49:
[Bild entfernt]
Re: [B.A.T.M.A.N.] [PATCH 03/13] batman-adv: Unify TTL handling
Andrew Lunn
an:
The list for a Better Approach To Mobile Ad-hoc Networking
16.02.2011 07:17
Kopie:
Linus L??ssing
On Tue, Feb 15, 2011 at 06:12:18PM +0100, Linus L??ssing wrote:
All our packets have a TTL and with the last batman header patch also
at
the same place in a batman encapsulated packet. We can therefore
savely
do one single TTL check before sending any batman packet type.
+static int recv_icmp_ttl_exceeded(struct bat_priv *bat_priv,
struct sk_buff *skb)+{
- struct orig_node *orig_node = NULL;
- struct neigh_node *neigh_node = NULL;
- struct icmp_packet *icmp_packet;
- int ret = NET_RX_DROP;
This is in the middle of the send path, so calling it recv_icmp_ttl_exceeded() seems a bit strange. I would say either send_icmp_ttl_exceeded() or recvd_icmp_ttl_exceeded() are better.
Andrew
Ah, yes, you're right, I missed that when I just moved the function. the recv_ naming does not make sense here anymore, correct, I'll change that.