Re: [B.A.T.M.A.N.] [PATCH] batctl: add raw wifi packet decapsulation support

On Friday 28 January 2011 18:24:16 Andrew Lunn wrote:

So i was expecting to see something like DSTODS. However the madwifi macros are for the complete DIR field, where as you are looking at individual bits. So

(fc & IEEE80211_FCTL_FROMDS) && (fc & IEEE80211_FCTL_TODS)

is equivalent to the madwifi IEEE80211_FC1_DIR_DSTODS.

So you header length calculation looks O.K.

I rather discuss potential bugs even if they turn out not to be bugs instead of letting them through. :)

Thanks for your review, Marek