Re: [B.A.T.M.A.N.] [PATCH v2 06/18] batman-adv: Place kref_get for orig_node near use

On Friday, July 15, 2016 17:39:21 Sven Eckelmann wrote:

It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting.

Signed-off-by: Sven Eckelmann sven@narfation.org

v2:

• split patch based on type

net/batman-adv/bat_iv_ogm.c | 7 ++++--- net/batman-adv/bat_v_ogm.c | 5 ++--- net/batman-adv/gateway_client.c | 2 +- net/batman-adv/network-coding.c | 7 +++---- net/batman-adv/originator.c | 1 - 5 files changed, 10 insertions(+), 12 deletions(-)

Applied in revision de6330c.

Thanks, Marek