Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove forward declaration by including proper header

On Wednesday 11 May 2016 18:47:30 Antonio Quartulli wrote: [...]

Maybe I could include it only when really needed, i.e.

• net/batman-adv/bat_algo.h
• net/batman-adv/bat_v_ogm.h

(netlink.h does not seem to be requiring it)

This is rather vague and hard to detect automatically. Potentially all files may require it because it has things like:

/* Debug Messages */ #ifdef pr_fmt #undef pr_fmt #endif /* Append 'batman-adv: ' before kernel messages */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Btw. Just looked at this file again and I should really consider redoing/rebasing the patches [1,2] from Markus Pargmann to clean it up.

Kind regards, Sven

[1] https://patchwork.open-mesh.org/patch/4264/ [2] https://patchwork.open-mesh.org/patch/4244/