Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: use eth_hdr() instead of skb->data in interface_tx path

On Saturday 18 January 2014 03:57:13 Linus Lüssing wrote:

Using eth_hdr() instead of skb->data avoids some ugly type casts.

I wasn't able to reproduce the skb ether header pointer mismatch mentioned in batadv_bla_tx() on a 3.11 kernel with a vlan on top of bat0 and therefore removed the according skb_reset_mac_header() call, too. In fact, it looks like it became obsolete with the following commit, included since 3.9:

"net: reset mac header in dev_start_xmit()" (6d1ccff627)

Maybe this falls into nitpicking but it sounds like 2 entirely different things for which you could send 2 patches (twice the fame!) ?

Cheers, Marek