On Saturday 28 May 2011 09:26:30 Sven Eckelmann wrote:
Yes, I suggested that because the tt patches will replace the first align with the ttvn field.
But it doesn't compile. I cannot forward stuff which is too broken. And personally I don't care who suggested it when my builtin c-parser explodes.
You got a point here. :-)
My suggestion: Rename the first align in every packet structure to 'reserved'.
Ok.
Then to the next part which I don't like: the patch forgot to touch batman_packet, icmp_packet, icmp_packet_rr, bcast_packet and vis_packet. It doesn't make sense to patch half of the on-wire types to reduce the number of COMPAT_VERSIONs.
If we touch every packet definition we also have to ensure that the code touching these packets does not implicitly assume certain positions (like route_unicast_packet() does).
Regards, Marek