Re: [B.A.T.M.A.N.] [PATCH-maint] batman-adv: Fix ICMP RR ethernet access after skb_linearize

On Sunday, May 29, 2016 21:25:52 Sven Eckelmann wrote:

The skb_linearize may reallocate the skb. This makes the calculated pointer for ethhdr invalid. But it the pointer is used later to fill in the RR field of the batadv_icmp_packet_rr packet.

Instead re-evaluate eth_hdr after the skb_linearize+skb_cow to fix the pointer and avoid the invalid read.

Fixes: bb69cb678d37 ("batman-adv: generalize batman-adv icmp packet handling") Signed-off-by: Sven Eckelmann sven@narfation.org

---

net/batman-adv/routing.c | 1 + 1 file changed, 1 insertion(+)

Applied in revision f6c80c2.

Thanks, Marek