On Fri, Dec 07, 2018 at 02:58:31PM +0100, Sven Eckelmann wrote:
The batman-adv configuration interface was implemented solely using sysfs. This approach was condemned by non-batadv developers as "huge mistake". Instead a netlink/genl based implementation was suggested.
Beside the mesh/soft-interface specific configuration, the VLANs on top of the mesh/soft-interface have configuration settings. The genl interface reflects this by allowing to get/set it using the vlan specific commands BATADV_CMD_GET_VLAN/BATADV_CMD_SET_VLAN.
The set command BATADV_CMD_SET_MESH will also notify interested userspace listeners of the "config" mcast group using the BATADV_CMD_SET_VLAN command message type that settings might have been changed and what the current values are.
Signed-off-by: Sven Eckelmann sven@narfation.org
Looks good.
Initially I was a bit confused with batadv_pre_doit() and thought you were missing to free the hard_iface in the "if (IS_ERR(vlan))" case. But then I remembered your initial WARN_ON() which ensures that hardif and vlan are exclusive.