Re: [B.A.T.M.A.N.] [PATCHv2 9/9] batman-adv: count batman_if list queries as reference

On Friday 17 September 2010 19:27:06 Sven Eckelmann wrote:

The return of get_batman_if_by_netdev and get_active_batman_if leaks a pointer from the rcu protected list of interfaces. We must protect it to prevent a too early release of the memory. Those functions must increase the reference counter before rcu_read_unlock or it may be to late to prevent a free.

It seems this patch does not properly deal with bat_priv->primary_if. Please review my revised patch and let me know if you think it is ok.

Cheers, Marek