Hi Antonio,
Thanks for looking at it, too :-).
On Mon, Jul 03, 2017 at 12:08:01PM +0800, Antonio Quartulli wrote:
[...]
Linus,
each originator announces flags covered by BATADV_TT_REMOTE_MASK (0x00FF), however you are extracting only those covered by BATADV_TT_SYNC_MASK (0x00F0).
Am I wrong or this is preventing the other 4 REMOTE flags (0x000F) to be set in tt_global_entry->common->flags (because you always filter them out when updating the entry)?
Hm, as far as I can tell, the ROAM flag is still set here: http://elixir.free-electrons.com/linux/latest/source/net/batman-adv/translat...
And unset here: http://elixir.free-electrons.com/linux/latest/source/net/batman-adv/translat...
And the TEMP flag is unset here: http://elixir.free-electrons.com/linux/latest/source/net/batman-adv/translat...
And is set... hm, ok, was the TEMP flag set by the now deleted "common->flags |= flags;"?
But then I'm confused, how would the TEMP flag have worked before patch fa614fd04692? Or was that patch not only supposed to fix the WIFI but also the TEMP flag?
If so, what would you prefer, should I replace the "common->flags |= flags" with something like a "common->flags |= flags & (~BATADV_TT_SYNC_MASK)"? Or would you prefer setting the TEMP flag somewhere else explicitly, similarly like we seemingly handle the ROAM flag explicitly, too?
Regards, Linus