-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
On 03/12/13 11:54, Simon Wunderlich wrote:
Hey Antonio,
On 02/12/13 20:38, Simon Wunderlich wrote:
struct batadv_icmp_header { uint8_t packet_type; @@ -208,18 +211,16 @@ struct batadv_icmp_header { uint8_t dst[ETH_ALEN]; uint8_t orig[ETH_ALEN]; uint8_t uid; + uint8_t rr_cur; + __be16 seqno; };
seqno was not in the header on purpose because new features may need a larger seqno space (e.g. the bw meter uses 32bits long seqnos). I think we have to re-work this structure differently..
ah ok, didn't know that. Well I also thought to move that uid into the other structures to have the icmp header at 16 bytes, but then we need to access the icmp_packet instead of icmp_header in functions like batadv_socket_write() - I changed that just recently. ;)
What do you suggest? These new types can't work with 16bit seqnos? :)
No, we can;t use 16bit seqnos for that...sorry :)
Right now I don't have a clear solution in mind. I'll try to look at that header closely tomorrow.
Cheers,
- -- Antonio Quartulli