Sat, Oct 29, 2016 at 01:46:59PM CEST, sven@narfation.org wrote:
On Samstag, 29. Oktober 2016 12:56:28 CEST Jiri Pirko wrote: [...]
I strongly believe it is a huge mistake to use sysfs for things like this. This should be done via generic netlink api.
This doesn't change the problem that it is already that way. This patch only adds the list of available files to the README.
Sure. Just found out you did it like that. Therefore I commented. I suggest to rework the api to use genl entirely.
Fair enough, I have added it to the issue tracker [1].
It seems there is no easy way to drop support for modifying batman-adv attributes of the interface or its ports via sysfs in the near future. But disallowing sysfs for new attributes might be a viable policy.
Cool. Thanks!
Kind regards, Sven