Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix NULL pointer deref in batadv_find_best_neighbor

On Thursday 26 December 2013 18:57:01 Simon Wunderlich wrote:

If there is no best neighbor, don't dereference the NULL pointer. Try to acquire the neighbor node right in the loop instead. There also was a logic bug, finding the worst instead of the best neighbor.

Introduced by 9bb33b8d88e318c4879d37d06ad28e3e018b9036 ("batman-adv: split tq information in neigh_node struct")

Signed-off-by: Simon Wunderlich sw@simonwunderlich.de

originator.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-)

Applied in revision 183150b.

Thanks, Marek