Re: [B.A.T.M.A.N.] [PATCHv4] batctl: Use netlink to replace some of debugfs

On Wednesday 04 May 2016 16:30:07 Andrew Lunn wrote:

+int netlink_print_originators(char *mesh_iface, int read_opts,

•                         float orig_timeout,
  

•                         float watch_interval)
  

+{

•   char *header;
  

•   int ifindex;
  

•   ifindex = if_nametoindex(mesh_iface);
  

•   if (!ifindex) {
  

•           fprintf(stderr, "Interface %s is unknown\n", mesh_iface);
  

•           return -ENODEV;
  

•   }
  

•   netlink_print_info(ifindex, PARSE_ONLY);
  

•   if (!algo_name)
  

•           return -EINVAL;
  

•   if (!strcmp("BATMAN_IV", algo_name))
  

•           header = "   Originator        last-seen (#/255) Nexthop           [outgoingIF]\n";
  

•   if (!strcmp("BATMAN_V", algo_name))
  

•           header = "   Originator        last-seen (throughput) Nexthop           [outgoingIF]\n ";
  

•   if (!header)
  

•           return -EINVAL;
  

•   return netlink_print_common(mesh_iface, read_opts, orig_timeout,
  

•                               watch_interval, header,
  

•                               BATADV_CMD_GET_ORIGINATORS,
  

•                               originators_callback);
  

+}

This is actually a report of a possible problem by Simon (I've only checked it):

It looks like the orig_iface handling isn't handled here (see handle_debug_table "case 'i'") or am I missing something? I would have expected that sets something like BATADV_ATTR_HARD_IFINDEX when orig_iface is available and the kernel then shows the same as in /sys/kernel/debug/batman_adv/$(hardif)/originators

The parameter BATADV_ATTR_HARD_IFINDEX seems to be already parsed by batadv_orig_dump. But batctl never seems to set it.

Kind regards, Sven