Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove forward declaration by including proper header

On Wed, May 11, 2016 at 02:24:04PM +0200, Sven Eckelmann wrote:

On Wednesday 11 May 2016 18:47:30 Antonio Quartulli wrote: [...]

...

Maybe I could include it only when really needed, i.e.

• net/batman-adv/bat_algo.h
• net/batman-adv/bat_v_ogm.h

(netlink.h does not seem to be requiring it)

This is rather vague and hard to detect automatically. Potentially all files may require it because it has things like:

/* Debug Messages */
#ifdef pr_fmt
#undef pr_fmt
#endif
/* Append 'batman-adv: ' before kernel messages */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

ok, how about adding it to any header file than (which is probably what you were suggesting in the first place)?

Cheers,