26 Apr
2016
26 Apr
'16
3 p.m.
On Tuesday 26 April 2016 17:42:54 Sergei Shtylyov wrote:
_batadv_update_route rcu_derefences orig_ifinfo->router outside of a spinlock protected region to print some information messages to the debug log. But this pointer is not checked again when the new pointer is assigned in the spinlock protected region. Thus is can happen that the value of
Thus is can? :-)
Yes, my fault. s/is/it/.
[...]
spin_lock_bh(&orig_node->neigh_list_lock);
- /* curr_router used earlier may not be the current orig_ifinfo->router
* anymore because it was dereferenced outside of the neigh_list_lock* protected region. After the new best neighbor has replace the currentReplaced.[...]
This one looks like one of Marek's modifications [1] to the patch. But I would guess that he has nothing against adding a 'd'.
Should Antonio resent all the patches or is a different approach preferred?
Kind regards, Sven