Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix random jitter calculation

From: Akinobu Mita akinobu.mita@gmail.com Date: Wed, 26 Dec 2012 21:32:10 +0900

batadv_iv_ogm_emit_send_time() attempts to calculates a random integer in the range of 'orig_interval +- BATADV_JITTER' by the below lines.

    msecs = atomic_read(&bat_priv->orig_interval) - BATADV_JITTER;
    msecs += (random32() % 2 * BATADV_JITTER);

But it actually gets 'orig_interval' or 'orig_interval - BATADV_JITTER' because '%' and '*' have same precedence and associativity is left-to-right.

This adds the parentheses at the appropriate position so that it matches original intension.

Signed-off-by: Akinobu Mita akinobu.mita@gmail.com Acked-by: Antonio Quartulli ordex@autistici.org

Applied, thanks.