Re: [syzbot] WARNING in batadv_nc_mesh_free

On 10/22/21 23:57, Pavel Skripkin wrote:

On 10/22/21 23:20, syzbot wrote:

...

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue: general protection fault in batadv_nc_purge_paths

Oh, ok. Next clean up call in batadv_nc_mesh_free() caused GPF, since fields are not initialized. Let's try to clean up one by one and do not break dependencies.

Quite ugly one, but idea is correct, I guess

Also, make each *_init() call clean up all allocated stuff to not call corresponding *_free() on error handling path, since it introduces problems, as syzbot reported

Whooops.... Forgot to ask syzbot to test the patch

#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

With regards, Pavel Skripkin