Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: don't access unregistered net_device object

On Tuesday, August 04, 2015 22:26:19 Antonio Quartulli wrote:

In batadv_hardif_disable_interface() there is a call to batadv_softif_destroy_sysfs() which in turns invokes unregister_netdevice() on the soft_iface. After this point we cannot rely on the soft_iface object anymore because it might get free'd by the netdev periodic routine at any time.

For this reason the netdev_upper_dev_unlink(.., soft_iface) call is moved before the invocation of batadv_softif_destroy_sysfs() so that we can be sure that the soft_iface object is still valid.

Signed-off-by: Antonio Quartulli antonio@meshcoding.com

net/batman-adv/hard-interface.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Applied in revision 958aafbb.

Thanks, Marek