On Saturday, July 1, 2017 6:47:11 PM HKT Linus Lüssing wrote:
On Sat, Jul 01, 2017 at 11:34:37PM +0800, Marek Lindner wrote:
On Friday, June 23, 2017 5:48:26 PM HKT Linus Lüssing wrote:
@@ -1946,6 +1977,7 @@ batadv_tt_global_dump_subentry(struct sk_buff *msg, u32 portid, u32 seq, struct batadv_tt_orig_list_entry *orig, bool best) {
u16 flags = (common->flags & (~BATADV_TT_SYNC_MASK)) |orig->flags;
Why do we need to output the combined global (partially masked) and the flags propagated by originator ? Shouldn't writing orig->flags be what we want ?
I thought it'd be helpful to be able to look at the sync flags on a per originator basis. So that users can more easily spot nodes with broken flags and can take action sooner.
Yeah, makes sense. Needed some help from Antonio to not get lost in the TT flags jungle.
Cheers, Marek