On Wednesday 23 June 2010 17:09:13 Andrew Lunn wrote:
There will be a ring buffer per mesh. When debugging problems between meshes it is likely both logs will be combined performing a merge based on the timestamp. However at this point you have lost information about which line belongs to which mesh. Could we maybe include the soft interface name in the output?
Actually, this information is (indirectly) present, since each log file resides inside debugfs/batman_adv/$mesh_if/log. It would be a little bit redundant to add this on every line, wouldn't you agree ? If someone merges 2 mesh files it still can be added ?
Also, do you really want to do jiffies / HZ? You are throwing away useful information. Either keep it as jiffies, or scale the remainder to ms and print it as well?
You are right - we could leave it as jiffies. Might be the best solution.
Regards, Marek