On Mon, 2012-11-19 at 20:29 +0100, Sven Eckelmann wrote:
On Monday 19 November 2012 18:52:30 Ben Hutchings wrote:
On Mon, 2012-11-19 at 09:24 +0100, Antonio Quartulli wrote:
Different versions of the batman-adv module may use the same compatibility version, but this is not understandable at runtime (the only way is to parse the kernel log and fetch the batman-adv advertisement message on loading). The user may want to know whether two nodes using different versions can communicate or not. For this purpose the module has to export this value through debugfs.
[...]
I do hope that you're not planning to use unstable debugfs interfaces indefinitely.
Why are you refering to the adding of an file as "incompatible" debugfs interface? I would call it additional information. And the rest of the commit message is talking about *possible* protocol incompatibilies of the network protocol (which caused this uncontrolled erruption of anger in a network maintainer).
I didn't say that. But debugfs tends to be exempted from expectations of interface stability or cleanliness (as it's for development, not production... right?). It's also an optional feature that might not be enabled at compile time or run-time. If BATMAN is ever going to be ready for general use it will need stable interfaces that are updated in a backward-compatible way and don't depend on debugfs.
Ben.