28 Jun
2015
28 Jun
'15
2:11 p.m.
On Monday, June 22, 2015 18:44:20 Antonio Quartulli wrote:
On 21/06/15 18:30, Marek Lindner wrote:
The hlist_del_rcu() call in batadv_tt_global_size_mod() does not check if the element still is part of the list prior to deletion. The atomic list counter should prevent the worst but converting to hlist_del_init_rcu() ensures the element can't be deleted more than once.
Signed-off-by: Marek Lindner mareklindner@neomailbox.ch
Acked-by: Antonio Quartulli antonio@meshcoding.com
Applied in revision 4729a33.
However, as discussed offline after Sven's suggestion in ticket #217, the entire if-loop still needs to be protected with the vlan_list_lock and not just its body.
I'll take care of that in a separate patch.
Regards, Marek