On Tuesday 03 May 2016 13:28:16 Simon Wunderlich wrote:
On Tuesday 03 May 2016 10:59:07 Sven Eckelmann wrote:
Hi,
here is the third version of the throughput meter support. It is just a rebased version of the patchset with two little bugfixes. Both problems were detected and reported by Antonio:
- batctl didn't check if the test_time is > 0 before doing a division
- batman-adv wasn't returning an error to batctl when dst was not reachable
I am currently unsure how we should proceed regarding the ICMP packet type used to communicate to the userspace ([PATCH 2/3]). Andrew+Matthias already prepared a netlink patchset which looks quite good and which should be tested+applied. The consequence for this patchset would be that patch 2 should be completely dropped and instead the tp_meter should become its own command in the netlink interface of batman-adv. Any opinions about that (order in which patches should be applied/netlink interface should be handled) by the Simon, Antonio, Marek, Matthias or Andrew?
Thanks for preparing the patchset! Antonio, Marek and me discussed and agreed that we should adopt the patchset as it is, and have the netlink support additionally at a later point.
Did read Antonio the comment in the internal ticket?
Kind regards, Sven