Re: [B.A.T.M.A.N.] [RFC 1/2] batman-adv: invoke post_func only if the attribute has been changed

6 Mar 2013


      On Wednesday, March 06, 2013 18:33:00 Antonio Quartulli wrote:
...
@@ -169,7 +169,7 @@ __batadv_store_bool_attr(char *buff, size_t count,
    ret = batadv_store_bool_attr(buff, count, net_dev, attr->name,
                                 attr_store);


  if (post_func && ret)




  if (post_func && ret > 0)
          post_func(net_dev);

  return ret;



If I remember correctly the shell or some other system between the kernel and 
userspace did not like to have 0 returned. It resulted in some funny "try to 
set this value over and over" reaction. You might want to test that.
Cheers,
Marek

    