Re: [B.A.T.M.A.N.] patch "staging: batman-adv: Use linux/etherdevice.h address helper functions" added to staging tree

On Wed, Nov 10, 2010 at 11:17:03AM +0100, Marek Lindner wrote:

Greg,

...

The patch is only compile-tested.

[..]

...

diff --git a/drivers/staging/batman-adv/main.c b/drivers/staging/batman-adv/main.c index 0587940..6ea6420 100644 --- a/drivers/staging/batman-adv/main.c +++ b/drivers/staging/batman-adv/main.c @@ -149,7 +149,7 @@ void dec_module_count(void)

int compare_orig(void *data1, void *data2) {

• return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);

• return (compare_ether_addr(data1, data2) == 0 ? 1 : 0);

}

I'm wondering why you accepted this patch despite the raised objections regarding alignment problems. [1][2]

Because at the end of that thread, it sounded like you all agreed that this patch was acceptable.

If not, then please let me know and I will revert it.

thanks,

greg k-h