On Thu, May 27, 2010 at 11:30:15PM +0800, Marek Lindner wrote:
On Thursday 27 May 2010 23:07:00 Andrew Lunn wrote:
I don't quite understand the problem. If you have implemented fragmentation, you will naturally increase the MTU on bat0 so that it is the standard for Ethernet. So this statement will not trigger.
AFAIK batman-adv determines the minimal MTU automatically, so that you can't simply increase the mtu on bat0. But you are right - if the fragmentation is enabled batman-adv could allow higher mtu values.
We discussed this a while ago. Actually fragmentation should be considered the last resort. It if first better to try header compression, to make the frame small enough that it can be sent without fragmentation. I think you had a quick look at using the PPP compression code, but i guess it did not go any further.
We only need to fragment when compression is not possible.
In either case, we should remove the automatic MTU calculation, and just offer the default for Ethernet. Let the compression and fragmentation code solve any differences.
Andrew