Re: [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: add UNICAST_4ADDR packet type

From: Sven Eckelmann sven@narfation.org Date: Sun, 04 Nov 2012 12:20:13 +0100

To push this question in a direction: May I assume that the driver always ensures that the ethernet header is 4 byte boundary - NET_IP_ALIGN (2) aligned?

Yes.

When yes, this would result in a slight variations of your suggestion: unicast/bcast headers have to end at 4 bytes boundary + 2 bytes. The reason is easy to explain. batman-adv unicast/bcast headers are used to encapsulate the important parts of an ethernet frame:

Ethernet Header for P2P | batman-adv header stuff | ethernet header | payload.

Would you aggree?

Then you can get rid of the packed crap.