Re: [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: fix rcu pointer comparison problem

On Sunday 24 November 2013 14:05:45 Simon Wunderlich wrote:

From: Simon Wunderlich simon@open-mesh.com

sparse complained about:

routing.c:482:64: error: incompatible types in comparison expression (different address spaces)

This was due to comparing a __rcu pointer with a regular one. Fix that by adding the missing rcu_dereference call. A temporary variable is used to comply with the line length limit, use the opportunity to beautify a few other places.

This problem was introduced in commit 797edd9e87ac838711e03498a4ae795b600191af ("batman-adv: add bonding again")

Signed-off-by: Simon Wunderlich simon@open-mesh.com

routing.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)

Applied in revision f2a1300.

Thanks, Marek