Re: [B.A.T.M.A.N.] [PATCHv4] batman-adv: remove obsolete deleted attribute for gateway node

On Monday, August 03, 2015 19:13:58 Simon Wunderlich wrote:

From: Simon Wunderlich simon@open-mesh.com

With rcu, the gateway node deleted attribute is not needed anymore. In fact, it may delay the free of the gateway node and its referenced structures. Therefore remove it altogether and simplify purging as well.

Signed-off-by: Simon Wunderlich simon@open-mesh.com

Changes to PATCHv3:

• remove unused variables

Changes to PATCHv2:

• use hlist_del_init_rcu() instead of looping through the list
• rename batadv_gw_node_purge() to batadv_gw_node_free() and remove obsolete mesh state check

Changes to PATCH:

• iterator through list to remove the element when deleting to avoid possible double list remove

---

net/batman-adv/gateway_client.c | 48 +++++++++++------------------------------ net/batman-adv/gateway_client.h | 2 +- net/batman-adv/main.c | 2 +- net/batman-adv/originator.c | 1 - net/batman-adv/types.h | 2 -- 5 files changed, 14 insertions(+), 41 deletions(-)

Applied in revision 0511575.

Thanks, Marek