On Wed, Feb 20, 2013 at 03:14:13PM +0100, Simon Wunderlich wrote:
On Wed, Feb 20, 2013 at 02:26:25PM +0100, Antonio Quartulli wrote:
Hi Simon,
ip link set dev $iface master bat0
This doesn't work. eth0 is not added to batman. To further test, I've added it via batctl.
I'm not sure..but I think this does not work because the "set master" command does not use ioctl, but rtnl only. Since in this kernel we don't have rtnl for these operations (this is why we have this hacky patch) I did not expect this command to work.
OK
Even more interesting are combinations of those:
- batctl if add $iface && some OGMS here && ip link set dev $iface nomaster &&
ip link del dev bat0
- ip link add dev bat0 type batadv && ip link set dev $iface master bat0 &&
some OGMS here && batctl if del $iface
Some of these combinations are tested above, but I'd suggest we should fix the general case first. :)
what would you like to fix? :) We have just implemented a feature and now we don't have any userspace tool which can exploit it! :-D
Well, if we don't expect this command to work then it's fine.
I just double-checked. iplink handles the master subcommand by sending a rtnl request with the IFLA_MASTER flasg set, nothing else. Unluckily, this flag is not supported in 2.6.32.
Personally I don't care as long as batctl works. :)
yeah, that's the important point. And batman-adv is still working with this patch.
If there are any other things to test, please let me know.
Nothing on my side. Thanks again :)
Cheers,