On Sun, Jul 28, 2013 at 09:10:33PM +0200, Braden Aran wrote:
Hi,
I get following important warnings when compiling alfred 2013.3.0
unix_sock.c: In function ‘unix_sock_req_data_finish’: unix_sock.c:261:7: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] write(client_sock, &status, sizeof(status)); ^ unix_sock.c: In function ‘unix_sock_req_data_reply’: unix_sock.c:187:8: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] write(client_sock, buf, sizeof(push->header) + len); ^
Thanks for bringing that to our attention ... yes, that should be fixed. This might become a problem if an alfred client is not reading fast enough and there is too much data who fill up the internal socket buffers. This will probably not be too problematic now, but might become later. :)
Would you like to propose a patch? Otherwise I'll probably fix it soon ...
Thanks, Simon