Re: [B.A.T.M.A.N.] [RFC 1/6] batman-adv: Add the initial code for network coding.

On 2012-11-26 01:23, Antonio Quartulli wrote:

...

+/**

...

• • struct batadv_priv - per mesh interface private data
• • @network_coding: enable/disable network coding
• • @batadv_priv_nc: network coding private data
• */

struct batadv_priv { atomic_t mesh_state; struct net_device_stats stats; @@ -308,6 +321,10 @@ struct batadv_priv { #ifdef CONFIG_BATMAN_ADV_DAT struct batadv_priv_dat dat; #endif +#ifdef CONFIG_BATMAN_ADV_NC

• atomic_t network_coding; /* boolean */

just another style note: why don't you put this boolean switch together with the others?

Because of the sysfs-framework in batman-adv, that expects an atomic_t with the same name as the file to be in batadv_priv - just like with your DAT and Simon's BLAII :)