Re: [B.A.T.M.A.N.] [PATCHv5 5/9] batman-adv: Distributed ARP Table - add snooping functions for ARP messages

On Friday, February 10, 2012 07:41:38 Antonio Quartulli wrote:

static inline void bat_dbg_arp(struct bat_priv *bat_priv, struct sk_buff *skb, uint16_t type) {

•   char buf[30];
  

•   const char *type_str[] = { "REQUEST", "REPLY", "RREQUEST",
  

"RREPLY", - "InREQUEST", "InREPLY", "NAK" }; -

•   if (type >= 1 && type <= ARRAY_SIZE(type_str))
  

•           scnprintf(buf, sizeof(buf), "%s", type_str[type - 1]);
  

•   else
  

•           scnprintf(buf, sizeof(buf), "UNKNOWN (%hu)", type);
  

•   bat_dbg(DBG_ARP, bat_priv, "ARP message of type %s recognised "
  

•           "[src: %pM-%pI4 dst: %pM-%pI4]\n", buf, ARP_HW_SRC(skb),
  

•           &ARP_IP_SRC(skb), ARP_HW_DST(skb), &ARP_IP_DST(skb));
  

•   bat_dbg(DBG_ARP, bat_priv, "ARP MSG = [src: %pM-%pI4 dst:
  

%pM-%pI4]\n", + ARP_HW_SRC(skb), &ARP_IP_SRC(skb), ARP_HW_DST(skb), + &ARP_IP_DST(skb)); }

Removing something that was just added in the previous patch is bad style and unlikely to be accepted.

Cheers, Marek