Re: [B.A.T.M.A.N.] [RFC] batman-adv: Reorder structs to reduce padding

On Sunday, November 04, 2012 06:41:48 Sven Eckelmann wrote:

•   struct batadv_neigh_node __rcu *router; /* rcu protected pointer */
  

#ifdef CONFIG_BATMAN_ADV_DAT batadv_dat_addr_t dat_addr; #endif

•   uint8_t flags;
  

•   uint8_t gw_flags;
  

•   struct batadv_neigh_node __rcu *router; /* rcu protected pointer */
  

Shouldn't we move batadv_dat_addr_t to the end of the struct to achieve the smallest possible struct regardless of whether DAT is compiled in or not ? Or does it have no effect ?

Cheers, Marek