Re: [B.A.T.M.A.N.] [PATCH] batman-adv: convert tt request list into hlist

On Friday, June 19, 2015 11:32:00 Sven Eckelmann wrote:

On Friday 19 June 2015 15:09:18 Marek Lindner wrote:

...

spin_lock_bh(&bat_priv->tt.req_list_lock);

• list_del(&tt_req_node->list);
  

• /* only remove tt_req_node if it still is in the list */
  

• if (!hlist_unhashed(&tt_req_node->list))
  

• 	hlist_del_init(&tt_req_node->list);
  
  

  spin_unlock_bh(&bat_priv->tt.req_list_lock); kfree(tt_req_node);

  }

hlist_del_init doesn't require the hlist_unhashed check because this is already done inside of this function [1].

Thanks! I did not know that. Will send a v2 shortly.

Cheers, Marek