Re: [B.A.T.M.A.N.] [PATCH 4/5] batctl: Parse non-variable TVLV only with correct length

On Wednesday 12 November 2014 18:58:28 Sven Eckelmann wrote:

The TVLV length has to be verified before the tvlv parser can start. Otherwise the tvlv parser might access invalid data.

Doing the same for zero length TVLVs is just good practice and might help finding problems easier.

This regression was introduced by 4c39fb823b86036df40187f8bd342fe5398c28ef ("batctl: tcpdump - parse TVLV containers").

Signed-off-by: Sven Eckelmann sven@narfation.org

tcpdump.c | 34 ++++++++++++++++++++++++++++------ 1 file changed, 28 insertions(+), 6 deletions(-)

Applied in revision 0505524.

Thanks, Marek