Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix transmission of final, 16th fragment

On Montag, 13. Februar 2017 20:44:31 CET Linus Lüssing wrote:

Trying to split and transmit a unicast packet in 16 parts will fail for the final fragment: After having sent the 15th one with a frag_packet.no index of 14, we will increase the the index to 15 - and return with an error code immediately, even though one more fragment is due for transmission and allowed.

Fixing this issue by moving the check before incrementing the index.

While at it, adding an unlikely(), because the check is actually more of an assertion.

Signed-off-by: Linus Lüssing linus.luessing@c0d3.blue

Applied in 464eff3b1768ff190466a453a57ac140ea5cb756 [1]

Thanks, Sven

[1] https://git.open-mesh.org/batman-adv.git/commit/464eff3b1768ff190466a453a57a...