On Wed, Dec 18, 2024 at 09:02:27AM +0100, Antonio Quartulli wrote:
I am not aware of 0 being used as a sane VID. I have seen it mostly used internally, but never truly used with something like "eth0.0".
Therefore I agree with Sven that this should not cause any real compat issue. If we truly break something, then we can probably assume that the scenario was already ill formed.
Ok, thanks you two for elaborating on this. Ok, these are good points. If no one uses VLAN 0 (in some partially broken/worked around/ out-of-spec way) and no one screams right now then I also like this change.
And would probably make sense to make this change now, before adding (some) VLAN learning to batman-adv. Where otherwise potentially less informed, random user (compared to node administrators?) would otherwise more likely use VLAN 0 in an unintended/out-of-spec way.