On Fri, 2018-05-25 at 14:13 +0300, Sergei Shtylyov wrote:
On 5/25/2018 1:50 PM, Sven Eckelmann wrote:
[...]
--- a/net/batman-adv/Kconfig +++ b/net/batman-adv/Kconfig @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS bool "batman-adv debugfs entries" depends on BATMAN_ADV depends on DEBUG_FS
default y
default nN is the default default. :-) You don't need this line.Hm, looks like this would have to be changed in a lot of places (~782 according to `git grep 'default n$'|wc -l` in my slightly outdated linux- next). Do you want to fix it everywhere?
No, but we can at least not add the new ones...Might be good to get this integrated in checkpatch.pl when this will become a new policy.
Adding Joe Perches. Joe, can you add a check for "default n"?
OK.
This also improves the Kconfig boolean->bool test above as it's broken for multiple section Kconfig files with help texts. --- scripts/checkpatch.pl | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index baddac9379f0..1f980be4950b 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2888,9 +2888,22 @@ sub process {
# discourage the use of boolean for type definition attributes of Kconfig options if ($realfile =~ /Kconfig/ && - $line =~ /^+\s*\bboolean\b/) { - WARN("CONFIG_TYPE_BOOLEAN", - "Use of boolean is deprecated, please use bool instead.\n" . $herecurr); + $rawline =~ /^+\s*\bboolean\b/) { + if (WARN("CONFIG_TYPE_BOOLEAN", + "Use of boolean is deprecated, please use bool instead.\n" . $herecurr) && + $fix) { + $fixed[$fixlinenr] =~ s/\bboolean\b/bool/; + } + } + +# discourage the use of 'default n' in Kconfig files as that's the default + if ($realfile =~ /Kconfig/ && + $rawline =~ /^+\s*default\s+n\s*$/) { + if (WARN("CONFIG_DEFAULT_N", + "Unnecessary Use of 'default n'\n" . $herecurr) && + $fix) { + fix_delete_line($fixlinenr, $rawline); + } }
if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&