Re: [B.A.T.M.A.N.] [RFC v3 14/19] batman-adv: Add multicast_mode mesh genl configuration

On Fri, Dec 07, 2018 at 02:58:41PM +0100, Sven Eckelmann wrote:

diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c index 8e3a1b6e..32762003 100644 --- a/net/batman-adv/netlink.c +++ b/net/batman-adv/netlink.c @@ -155,6 +155,7 @@ static const struct nla_policy batadv_netlink_policy[NUM_BATADV_ATTR] = { [BATADV_ATTR_GW_SEL_CLASS] = { .type = NLA_U32 }, [BATADV_ATTR_HOP_PENALTY] = { .type = NLA_U8 }, [BATADV_ATTR_LOG_LEVEL] = { .type = NLA_U32 },

• [BATADV_ATTR_MULTICAST_MODE] = { .type = NLA_U8 },

};

Since the name is more generic than just a flag, would it make sense to make this a U32, just to stay flexible for the future?

(I don't have any specific ideas or plans to use more values for it right now, though)