Re: [B.A.T.M.A.N.] [PATCH v2 1/5] batman-adv: make the GW selection class algorithm specific

On Mon, May 23, 2016 at 10:09:12PM +0800, Antonio Quartulli wrote:

On Mon, May 23, 2016 at 05:00:33PM +0800, Antonio Quartulli wrote:

...

+static ssize_t batadv_store_gw_sel_class(struct kobject *kobj,

• 			 struct attribute *attr, char *buff,
  

• 			 size_t count)
  

+{

• struct batadv_priv *bat_priv = batadv_kobj_to_batpriv(kobj);
• if (buff[count - 1] == '\n')

• buff[count - 1] = '\0';
  

• if (bat_priv->bat_algo_ops->gw.bat_store_sel_class)

• return bat_priv->bat_algo_ops->gw.bat_store_sel_class(bat_priv,
  

• 						      buff,
  

• 						      count);
  

• return __batadv_store_uint_attr(buff, count, 0, BATADV_TQ_MAX_VALUE,

unfortunately the min value is still 0 - it should be kept to 1 as it was in the original code.

...

• 			batadv_post_gw_reselect, attr,
  

• 			&bat_priv->gw.sel_class,
  

• 			bat_priv->soft_iface);
  

+}

I just realized that no post function is invoked here, thus changing the expected behaviour.

ah no - this is just wine effect...__batadv_store_uint_attr() takes care of calling batadv_post_gw_reselect().

Only one fix needed then :)

Cheers,