Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Avoid double freeing of bat_counters

On Wednesday, April 17, 2013 20:36:46 Martin Hundebøll wrote:

--- a/soft-interface.c +++ b/soft-interface.c @@ -497,12 +497,10 @@ static int batadv_softif_init_late(struct net_device *dev) ret = batadv_mesh_init(dev); if (ret < 0)

•           goto unreg_debugfs;
  

•           batadv_debugfs_del_meshif(dev);
  
  

•   return 0;
  

•   return ret;
  
  

-unreg_debugfs:

•   batadv_debugfs_del_meshif(dev);
  

free_bat_counters: free_percpu(bat_priv->bat_counters);

This looks like a valid problem but I do suggest setting bat_priv-

bat_counters to NULL after calling free_percpu(). Otherwise we will run into

this problem again when somebody else changes the order of the calls ...

Cheers, Marek