Ah, sorry, and skip the functions.c-part please, I had submitted a seperate patch for that here already.
Cheers, Linus
On Fri, Dec 11, 2009 at 11:58:35PM +0100, Linus Lüssing wrote:
Hi Andrew,
your patch seems to work pretty well here, tested it with 9 batman-nodes in the same room. Nevertheless I found a couple of smaller bugs in there:
- batctl segfaults, if "batctl vis" has no following argument
- batctl now displays the help-page in certain situations where we don't want it to
- batctl ommits the first TQ tupel
The attached patch for your patch should fix these issues :).
And I wanted to ask, what do you think about unifying the specific help output? For instance having this "Usage: ..."-header and the alignment for the following items the same way as it is done for other batctl commands as well.
Cheers, Linus
PS: Hmm, I'm also missing a couple of link/TQ entries already in the unified /proc/../vis. The 9 nodes in the same room should be able to see each other - the originator table on those nodes is also saying so. But I think I had seen this before without your patch, the problems has to be somewhere else. I'm attaching a batctl-vis- and proc-vis-output of the setup here too, just in case someone might spot some (more) parsing mistakes.