Hi Sven,
I just pressed the send button too early for my last mail ;-).
First of all I want to thank you for your valuable review. Please be patient as this is my first attempt to contribute to a linux project and I am still lacking some linux know how.
Kind regards, Andreas
Sven Eckelmann sven@narfation.org schrieb am 26.02.2016 17:20:54:
Von: Sven Eckelmann sven@narfation.org An: b.a.t.m.a.n@lists.open-mesh.org Kopie: Andreas Pape apape@phoenixcontact.com Datum: 26.02.2016 17:21 Betreff: Re: [B.A.T.M.A.N.] [Patchv2 0/7] batman-adv: Optimizations for setups running dat and bla
On Friday 26 February 2016 14:16:38 Andreas Pape wrote:
This patchset introduces optimizations for batman-adv in setups having several gateways into a common (switched) Ethernet backbone network especially if dat is additionally enabled.
[...]
See my other comments directly to the patches. Please try to set the in-reply-to of the patches to the message-id of the cover letter.
Otherwise
the messages aren't correctly threaded on the mailinglist [1].
And you can set the version number of the patch directly using git-format-patch:
git format-patch -v 2 origin/masterI haven't done the complete build_test run but at least a quick test
against
4.4 only. The result is attached.
Kind regards, Sven
[1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-February/ thread.html [Anhang "build-test_andreas-pape_bla-fixes.mbox" gelöscht von Andreas Pape/Phoenix Contact] [Anhang "signature.asc" gelöscht von Andreas Pape/Phoenix Contact]
.................................................................. PHOENIX CONTACT ELECTRONICS GmbH
Sitz der Gesellschaft / registered office of the company: 31812 Bad Pyrmont USt-Id-Nr.: DE811742156 Amtsgericht Hannover HRB 100528 / district court Hannover HRB 100528 Geschäftsführer / Executive Board: Roland Bent, Dr. Martin Heubeck ___________________________________________________________________ Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren, jegliche anderweitige Verwendung sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. ---------------------------------------------------------------------------------------------------- This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure, distribution or other use of the material or parts thereof is strictly forbidden. ___________________________________________________________________