On Thursday, June 30, 2016 16:00:10 Sven Eckelmann wrote:
On Thursday 30 June 2016 10:09:25 Linus Lüssing wrote:
Since recently the multicast optimizations are using functions from the bridge module. If batman-adv is a kernel built-in, then these bridge functions need to be accessible immediately. Thus adding a Kconfig dependency for the multicast optimizations to depend on batman-adv being built as a module if the bridge is built as a module, too.
[...]
config BATMAN_ADV_MCAST bool "Multicast optimisation"
depends on BATMAN_ADV && INET
depends on BATMAN_ADV && INET && !(BRIDGE=m && BATMAN_ADV=y) default n help This option enables the multicast optimisation which aims toThe used functions are provided via stubs in include/linux/if_bridge.h when bridge is disabled. So the symbols are only missing when the batman-adv code is compiled as part of the kernel but the bridge code is compiled as modules. So this change seems to make sense.
Reviewed-by: Sven Eckelmann sven@narfation.org
Applied in revision e917bb4.
Thanks, Marek