Re: [B.A.T.M.A.N.] [PATCH v5 1/4] batman-adv: make the GW selection class algorithm specific

On Mon, Jun 13, 2016 at 12:45:17PM +0200, Sven Eckelmann wrote:

On Sunday 12 June 2016 12:14:23 Antonio Quartulli wrote: [...]

...

• if (bat_priv->algo_ops->gw.show_sel_class)

• return bat_priv->algo_ops->gw.show_sel_class(bat_priv, buff);
  

[...]

...

• if (bat_priv->algo_ops->gw.store_sel_class)

• return bat_priv->algo_ops->gw.store_sel_class(bat_priv, buff,
  

• 					      count);
  

[...]

...

/**

• • struct batadv_algo_gw_ops - mesh algorithm callbacks (GW specific)
• • @store_sel_class: parse and stores a new GW selection class
• • @show_sel_class: prints the current GW selection class
• */

+struct batadv_algo_gw_ops {

• ssize_t (*store_sel_class)(struct batadv_priv *bat_priv, char *buff,

• 		   size_t count);
  

• ssize_t (*show_sel_class)(struct batadv_priv *bat_priv, char *buff);

+};

Looks like these two are also optional. Can someone please add the "(optional)" string to the kernel-doc like it was done in the initial batadv_algo_ops patches? Thanks

Same for get_best_gw_node, is_eligible and print in patch 2

Sure!

Thanks!