Re: [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb

On 23/12/13 00:50, David Miller wrote:

See nf_reset() and skb_scrub_packet(). Do not reinvent the wheel.

Hello David,

after some discussion[1] the suggestion was to keep the behaviour as less intrusive as possible, thus I avoided any nf_reset() (and similar) and I directly wrote my function that calls nf_bridge_put() only.

Do you think it is safe to use nf_reset() directly? Pablo was worried about "strange" user configurations that may break because of this. (Even if somebody may argue that in this case user configurations are probably broken, not the kernel :-) ).

Regards,

[1] http://thread.gmane.org/gmane.linux.network/286965/focus=287502