Re: [B.A.T.M.A.N.] [PATCHv3 7/9] batman-adv: adapt the neighbor purging routine to use the new API functions

On Tuesday, August 13, 2013 14:43:50 Antonio Quartulli wrote:

--- a/originator.c +++ b/originator.c @@ -380,6 +380,8 @@ batadv_purge_orig_neighbors(struct batadv_priv *bat_priv, bool neigh_purged = false; unsigned long last_seen; struct batadv_hard_iface *if_incoming;

•   struct batadv_algo_ops *bao = bat_priv->bat_algo_ops;
  

•   uint32_t neigh_metric, best_metric = UINT_MAX;
  

Albeit being not wrong I'd rather initialize best_metric with zero. It was confusing when reading the first time.

Cheers, Marek